UI: Redesign ChoiceParam UI component #2656
Open
+195
−194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-design the UI control for editing a ChoiceParam.
Exclusive ChoiceParam
The exclusive ChoiceParam component has been resigned to address multiple issues with the current controls.
Before
Behavior
Custom Value indicator
After (this PR)
Behavior
Custom value indicator
Non-exclusive ChoiceParam
This component has been redesigned to display custom values outside the range of possible values.
That may happen when a node description is modified and potentially discard already serialized value in existing scenes.
This can be tried out by pasting this code snippet in Meshroom's script editor:
Features list
Exclusive ChoiceParam
Non exclusive ChoiceParam
Implementation remarks
FilterComboBox
Rely as much as possible on the behaviors provided by the default ComboBox component to avoid custom logic for e.g keyboard navigation.
Move away from imperative code for handling value binding, simplifying the usage of the FilterComboBox component and making sure that the displayed value is always reflecting the actual attribute's value.
Simplify the filtering logic.
AttributeControls
Introduce a new subfolder (
AttributeControls
) to host the controls to view and edit attributes, in order to reduce the complexity ofAttributeItemDelegate.qml
.