Introduce new attribute type: DynamicChoiceParam #2661
+276
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new ChoiceParam-like type that supports the override and serialization of the list of possible values.
GroupAttribute subclasses can override their `value` property to return the value of a child attribute. The `nodeCopy` method needs to evaluate the group's actual value. Therefore, make sure to access the GroupAttribute's internal value and not an overriden one.
yann-lty
force-pushed
the
dev/dynamicChoiceParam
branch
from
57e5e92 to
70546c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2661 +/- ##
===========================================
+ Coverage 69.93% 70.49% +0.56%
===========================================
Files 121 122 +1
Lines 7088 7199 +111
===========================================
+ Hits 4957 5075 +118
+ Misses 2131 2124 -7 ☔ View full report in Codecov by Sentry. |
Skip value assignment when the value is a list identical to the ListAttribute's current value. This avoids internal models and graph update, which can have a significant impact on performance when the number of elements grows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
DynamicChoiceParam, which provides the same feature set as a ChoiceParam but supports override and serialization of the list of possible values.Features list
Implementation remarks
DynamicChoiceParam is implemented as a specialized GroupAttribute, composed of 2 child attributes:
Relying on a GroupAttribute allows to benefit from the existing serialization logic.
This has been preferred over implementing a specific serialization logic for the existing ChoiceParam type.