Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka dependency #5743

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix kafka dependency #5743

merged 1 commit into from
Jan 28, 2025

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 27, 2025

No description provided.

@ktf ktf requested a review from a team as a code owner January 27, 2025 16:50
@ktf
Copy link
Member Author

ktf commented Jan 27, 2025

@Barthelemy @vascobarroso we also need this, I guess..

@vascobarroso vascobarroso requested a review from sy-c January 27, 2025 19:20
@vascobarroso
Copy link
Contributor

@sy-c could you review ?

Copy link
Contributor

@sy-c sy-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't grasp the meaning, but I'm sure this is fine

@ktf
Copy link
Member Author

ktf commented Jan 28, 2025

The point is that if libkafka is not available (hence LIBRDKAFKA_REVISION is not set by alibuild) we should not add the option to CMake.

@ktf ktf merged commit 85acdbf into alisw:master Jan 28, 2025
10 of 13 checks passed
@knopers8
Copy link
Contributor

knopers8 commented Feb 3, 2025

It seems it could have introduced an issue in QC PR checks for o2-dataflow:

ninja: error: '/local/workspace/DailyBuilds/DailyO2Dataflow-slc8/daily-tags.cZi7Jrsli5/slc8_x86-64/librdkafka/v2.3.0-14/lib/librdkafka++.so', needed by 'stage/lib64/libO2Framework.so', missing and no known rule to make it

Somehow librkafka++ became a dependency of O2Framework, is that intentional?

@sy-c
Copy link
Contributor

sy-c commented Feb 3, 2025

libmonitoring now depends explicitely on kafka. So whatever depends on libmonitoring also depends on kafka.

@ktf
Copy link
Member Author

ktf commented Feb 3, 2025

I think it needs to either be marked as a private dependency, or we need to add the find_package also to O2.

@Barthelemy
Copy link
Contributor

So... who is doing what ?
I cannot reproduce this issue on my mac nor on our jenkins under rhel9 and cs8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants