-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kafka dependency #5743
Fix kafka dependency #5743
Conversation
@Barthelemy @vascobarroso we also need this, I guess.. |
@sy-c could you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't grasp the meaning, but I'm sure this is fine
The point is that if libkafka is not available (hence LIBRDKAFKA_REVISION is not set by alibuild) we should not add the option to CMake. |
It seems it could have introduced an issue in QC PR checks for
Somehow |
libmonitoring now depends explicitely on kafka. So whatever depends on libmonitoring also depends on kafka. |
I think it needs to either be marked as a private dependency, or we need to add the find_package also to O2. |
So... who is doing what ? |
No description provided.