Django 2.2 #3873
Merged
Django 2.2 #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run ruff
Fix imports with ruff
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hipek8
commented
Dec 6, 2024
Comment on lines
+622
to
+627
| # def get_queryset(self): | ||
| # return ( | ||
| # super() | ||
| # .get_queryset() | ||
| # .annotate(objects_count=Count("support__baseobjectssupport")) | ||
| # ) |
There was a problem hiding this comment.
Decide what to do with it.
Otherwise python 3.8 complains with garbage
RuntimeError: __class__ not set defining 'BaseObjectsSupportRichResource' as <class 'ralph.data_importer.resources.BaseObjectsSupportRichResource'>. Was __classcell__ propagated to type.__new__?
or when fixed in ImportForeignKeyMeta:
TypeError: __class__ set to <class 'ralph.data_importer.resources.BaseObjectsSupportRichResource'> defining 'BaseObjectsSupportRichResource' as <class 'ralph.data_importer.resources.BaseObjectsSupportRichResource'>
matyldv
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - Use ruff in CI instead of flake and isort