bugfix_french_converter #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix for french convertion: deux cents euros deux cent mille euros, cent ne prends pas de "s"
MaciejLipinski
requested changes
Nov 12, 2021
| private final Map<Integer, String> exceptions; | ||
| private final Map<Integer, String> exceptions; | ||
|
|
||
| private boolean baseNumbers = false; |
There was a problem hiding this comment.
Please remove this, this is not a good pattern. Add a private method private String asWords(Integer value, boolean isBaseNumber), move code from public String asWords(Integer value) and call it from there with true. Call it from getThousandsAsWords with false (currently line 57).
| @@ -94,7 +94,7 @@ class FrenchValuesTest extends Specification { | |||
| 24_190 | "vingt-quatre mille cent quatre-vingt-dix" | |||
| 653_000 | "six cent cinquante-trois mille" | |||
| 123_454 | "cent vingt-trois mille quatre cent cinquante-quatre" | |||
| 700_000 | "sept cents mille" | |||
| 700_000 | "sept cent mille" | |||
There was a problem hiding this comment.
what about sept cent millions? should it be cent or cents? Now it's cents
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for french convertion:
deux cents euros
deux cent mille euros, cent ne prends pas de "s"
Added convertion process for Millions.