-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: basic marimekko #1011
base: master
Are you sure you want to change the base?
WIP: basic marimekko #1011
Conversation
97d77cd
to
35593e4
Compare
… here or maybe change size in e2e test
⏱️ Lighthouse report |
size-limit report 📦
|
✅ Deployed successfully to: https://turnilo-marimekko-gmbbyye42a-ew.a.run.app |
⏱️ Lighthouse report |
✅ Deployed successfully to: https://turnilo-marimekko-gmbbyye42a-ew.a.run.app |
@@ -37,9 +37,9 @@ export function omitFalsyValues<T>(obj: T): Partial<T> { | |||
|
|||
type Key = string; | |||
|
|||
export function mapValues<K extends Key, S, T>(obj: Record<K, S>, fn: Unary<S, T>): Record<K, T> { | |||
export function mapValues<K extends Key, S, T>(obj: Record<K, S>, fn: Binary<S, K, T>): Record<K, T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit test for added keys parameter
@@ -24,7 +24,7 @@ import { LinearScale } from "../../../utils/linear-scale/linear-scale"; | |||
const MARGIN = 40; | |||
const X_AXIS_HEIGHT = 50; | |||
const Y_AXIS_WIDTH = 50; | |||
const BREAKPOINT_SMALL = 768; | |||
const BREAKPOINT_SMALL = 748; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we change it here? Or adjust e2e test for Large Screen?
@@ -509,7 +509,8 @@ export class CubeView extends React.Component<CubeViewProps, CubeViewState> { | |||
return menuStage.within({ | |||
left, | |||
right, | |||
top: CONTROL_PANEL_HEIGHT | |||
top: CONTROL_PANEL_HEIGHT, | |||
bottom: 20 // TODO: from .cube-view .center-panel margins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, somehow we should resolve this. Right now visualisations have bigger stage than is available.
@@ -0,0 +1,209 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is as WIP as it gets.
No description provided.