feat: EIP-7742 #1600
Open
feat: EIP-7742 #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
klkvr
force-pushed
the
klkvr/eip7742
branch
2 times, most recently
from
55ac6ae
to
b283c74
Compare
mattsse
approved these changes
Nov 1, 2024
| /// Similar to [crate::eip4844::calc_excess_blob_gas], but derives the target blob gas from | ||
| /// `parent_target_blob_count`. | ||
| #[inline] | ||
| pub const fn calc_excess_blob_gas( |
There was a problem hiding this comment.
I'm a bit concerned that this will be easy to misuse if the functions have the same name, but since this takes an additional param this is okay imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7742.md
ethereum/execution-apis#574
ethereum/EIPs#8994
Block::next_block_blob_feeis updated to accept optionalnext_block_target_blob_countparameter. If provided, we are using EIP-7742 to calculate the blob feePayloadAttributeswithtarget_blobs_per_blockandmax_blobs_per_block.Some PRs are not merged and field names are different per different specs for now, but besides that this should be complete
Solution
PR Checklist