feat: Add Blob type that behaves like Bytes #1912
Open
+195
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
mattsse
requested changes
Jan 13, 2025
|
Two tests are currently failling |
mattsse
requested changes
Jan 26, 2025
There was a problem hiding this comment.
let's undo all of the changes here
There was a problem hiding this comment.
same
I want to focus only on the additional type first
| @@ -86,9 +91,146 @@ pub const BYTES_PER_COMMITMENT: usize = 48; | |||
|
|
|||
| /// How many bytes are in a proof | |||
| pub const BYTES_PER_PROOF: usize = 48; | |||
| /// A fixed-size container for binary data, designed to hold exactly 131,072 bytes. | |||
| #[derive(Clone, Debug, RlpEncodable, RlpDecodable, Hash, PartialEq, Eq)] | |||
There was a problem hiding this comment.
RlpDecodable we can't derive but must impl manually because we also need to enforce length
| } | ||
| } | ||
| #[cfg(feature = "serde")] | ||
| impl serde::Serialize for Blob { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently docs are missing but lmk if changes are needed, if not, i'll add docs @mattsse