feat(sol!
): make #[sol(rpc)]
default if rpc
feat enabled
#852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when expanding contracts in the
sol!
therpc
attribute is not enabled by default. Users must explicitly enable using#[sol(rpc)]
.Solution
Introduces
"rpc"
feature that is propagated fromalloy-core
toalloy-sol-macro-expander
.Enabling this feature expands the contract with RPC-related code.
Now, one can make use of
ContractInstance::new(addr, provider)
without having to specify#[sol(rpc)]
.RPC-related methods can be disabled using
#[sol(rpc = false)]
.Note: Enabling this by default requires the user to install
alloy-contract
.PR Checklist