Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(providers): wrapped provider #171

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat(providers): wrapped provider #171

wants to merge 7 commits into from

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Jan 6, 2025 •
edited
Loading

Motivation

Ref alloy-rs/alloy#1859

Solution

Demonstrate how to pass a provider in a free function and wrap it in a custom type

Merge after alloy 0.1 bump

PR Checklist

  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya changed the base branch from main to dani/alloy-0.10 January 6, 2025 14:58
gakonst
gakonst reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need impl Provider return type statement and Contract example

@yash-atreya yash-atreya changed the base branch from dani/alloy-0.10 to main January 7, 2025 15:54
@yash-atreya yash-atreya requested a review from gakonst January 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst Awaiting requested review from gakonst

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @gakonst @DaniPopes