feat(anvil): add anvil examples from ethers-rs
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
anvil examples from ethers-rsanvil examples from ethers-rs
zerosnacks
commented
Mar 15, 2024
mattsse
requested changes
Mar 15, 2024
Comment on lines
+49
to
+53
| let base_fee = provider.get_gas_price().await?; | ||
|
|
||
| // Deploy the contract. | ||
| let contract_builder = Counter::deploy_builder(&provider); | ||
| let estimate = contract_builder.estimate_gas().await?; |
There was a problem hiding this comment.
I think we want to change the return value from U64 to u64 for all of these to make it easier to use, usually u64 is beneficial
There was a problem hiding this comment.
Will implement once alloy-rs/alloy#338 is merged
Co-authored-by: Matthias Seitz <[email protected]>
mattsse
requested changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: alloy-rs/alloy#301
Motivation
To add examples from
ethers-rs:anvilSolution
Includes a new Anvil test (
deploy_contract) that was planned inethers-rsbut not added originally. Adds two other very basic tests for forking and local.I'm currently managing the
nonces,gasandgas_pricemanually which is not ideal. Preferablygasandgas_priceare derived automatically. I think it is preferable to add support for nonce management to the examples at a later point.