chore(rpc-types): Preferred Type #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
|
Needs review from @emhane |
emhane
approved these changes
Jan 10, 2025
| /// Types are preferred as follows: | ||
| /// - Deposit Transactions if `chain_id` is not set | ||
| /// - EIP-7702 if authorization_list is set | ||
| /// - EIP-4844 if sidecar or max_blob_fee_per_gas is set |
There was a problem hiding this comment.
Suggested change
| /// - EIP-4844 if sidecar or max_blob_fee_per_gas is set |
Comment on lines
+97
to
+101
| /// - EIP-7702 if authorization_list is set | ||
| /// - EIP-4844 if sidecar or max_blob_fee_per_gas is set | ||
| /// - EIP-2930 if access_list is set | ||
| /// - Legacy if gas_price is set and access_list is unset | ||
| /// - EIP-1559 in all other cases |
There was a problem hiding this comment.
Suggested change
| /// - EIP-7702 if authorization_list is set | |
| /// - EIP-4844 if sidecar or max_blob_fee_per_gas is set | |
| /// - EIP-2930 if access_list is set | |
| /// - Legacy if gas_price is set and access_list is unset | |
| /// - EIP-1559 in all other cases | |
| /// - See [`TransactionRequest::preferred_type`]. |
I just delegate docs when I delegate a call, that way I know I don't create doc bugs in future
| TxType::Eip1559 => OpTxType::Eip1559, | ||
| TxType::Eip2930 => OpTxType::Eip2930, | ||
| // EIP-4844 transactions are not supported by Optimism. | ||
| TxType::Eip4844 => OpTxType::Eip1559, |
There was a problem hiding this comment.
maybe add a debug log here as well
mattsse
reviewed
Jan 10, 2025
Comment on lines
+103
to
+105
| if self.0.chain_id.is_none() { | ||
| return OpTxType::Deposit; | ||
| } |
There was a problem hiding this comment.
this function is intended for clients sending txs, should we return deposit here?
There was a problem hiding this comment.
Does it make sense if the chain_id is none that deposit is returned and the client should reject the tx?
There was a problem hiding this comment.
Alternatively we remove this and just fall-through to the TransactionReceipt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28.
Implements the
preferred_typemethod on theOpTransactionRequest.