enable cross-browser testing in cucumber reporter (via #737)

allure-framework · Aug 4, 2023 · b0201a4 · b0201a4
1 parent a7e8fb2
commit b0201a4
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/packages/allure-cucumberjs/README.md b/packages/allure-cucumberjs/README.md
@@ -208,3 +208,17 @@ Given(/my step/, async function () {
   });
 });
 ```
+
+## Cross-browser testing
+
+For cross-browser testing simply add a parameter using Allure API with the browser name to the `World` instance inside your scenario, i.e.:
+
+```js
+await this.parameter('Browser', 'firefox')
+```
+
+For better presentation, you can also group suites by browser names, i.e.:
+
+```js
+await this.parentSuite('Firefox')
+```
diff --git a/packages/allure-cucumberjs/src/CucumberJSAllureReporter.ts b/packages/allure-cucumberjs/src/CucumberJSAllureReporter.ts
@@ -506,6 +506,7 @@ export class CucumberJSAllureFormatter extends Formatter {
       currentTest.status = Status.PASSED;
     }
 
+    currentTest.calculateHistoryId();
     currentTest.endTest(Date.now());
 
     this.currentTestsMap.delete(data.testCaseStartedId);

diff --git a/packages/allure-cucumberjs/test/specs/simple_test.ts b/packages/allure-cucumberjs/test/specs/simple_test.ts
@@ -29,6 +29,19 @@ const dataSet: { [name: string]: ITestFormatterOptions } = {
       },
     ],
   },
+  parameterized: {
+    supportCodeLibrary: buildSupportCodeLibrary(({ Given }) => {
+      Given("a step", function () {
+        this.parameter("Browser", "firefox");
+      });
+    }),
+    sources: [
+      {
+        data: ["Feature: a", "Scenario: b", "Given a step"].join("\n"),
+        uri: "a.feature",
+      },
+    ],
+  },
 };
 
 describe("CucumberJSAllureReporter > simple", () => {
@@ -76,17 +89,20 @@ describe("CucumberJSAllureReporter > simple", () => {
     });
 
     it("sets fullName, testCaseId and historyId", async () => {
-      const results = await runFeatures(dataSet.passed);
+      const results = await runFeatures(dataSet.parameterized);
 
       expect(results.tests).length(1);
       const [testResult] = results.tests;
       const source = dataSet.passed.sources?.[0];
 
       const name = source!.data.match(/\nScenario: (.+)\n/)?.[1];
       const fullName = `${source!.uri}#${name!}`;
+      const { name: paramName, value: paramValue } = testResult.parameters[0];
+      const paramsHash = md5(`${paramName}:${paramValue}`);
+      const historyId = `${testResult.testCaseId}:${paramsHash}`;
       expect(testResult.fullName).eq(fullName);
       expect(testResult.testCaseId).eq(md5(fullName));
-      expect(testResult.historyId).eq(testResult.testCaseId);
+      expect(testResult.historyId).eq(historyId);
     });
   });