Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History ID and metadata processing improvements #748

Merged
merged 3 commits into from
Aug 16, 2023
Merged

History ID and metadata processing improvements #748

merged 3 commits into from
Aug 16, 2023

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Aug 14, 2023 •
edited
Loading

Context

fixes #747

  • Adds ability to set testCaseId and historyId manually.
  • Fixes problem with lack of testCaseId for hermione
  • Introduces new test method to parse and apply metadata messages and uses the method for hermione and cucumber integrations

Checklist

@epszaw epszaw added type:bug Something isn't working theme:hermione labels Aug 14, 2023
@github-actions github-actions bot added theme:api Javascript API related issue theme:cucumberjs CucumberJS related issue labels Aug 14, 2023
@epszaw epszaw requested a review from baev August 14, 2023 14:56
@epszaw epszaw force-pushed the issue-747-fix-hermione-test-case-id branch from 2a6e165 to ee70787 Compare August 15, 2023 11:13
@epszaw epszaw changed the title Add method to calculate test case id History ID and metadata processing improvements Aug 15, 2023
@baev baev merged commit 9337694 into master Aug 16, 2023
5 checks passed
@baev baev deleted the issue-747-fix-hermione-test-case-id branch August 16, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:api Javascript API related issue theme:cucumberjs CucumberJS related issue theme:hermione type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hermione reporter doesn't assign testCaseId
2 participants
@epszaw @baev