Add better description handler for cucumber features #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epszaw
added
type:bug
epszaw
changed the title
baev
requested changes
Aug 18, 2023
| // sometimes description starts with "Description:", but it's not actually required | ||
| const description = scenario?.description | ||
| ? scenario.description.replace(/\s+Description:\s?/, "") | ||
| : doc?.feature?.description; |
There was a problem hiding this comment.
Maybe always join the feature description with the scenario description?
There was a problem hiding this comment.
I afraid it'll produce strange descriptions with a lot of duplicated data. Guess, we should entirely replace feature description by a local one
epszaw
force-pushed
the
issue-740-fix-cucumber-description-keyword-handling
branch
from
2c2db42
to
a81126e
Compare
baev
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fixes #740
Checklist