Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change skipped tests handling logic #758

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Change skipped tests handling logic #758

merged 2 commits into from
Sep 4, 2023

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Aug 22, 2023

Context

fixes #757

Checklist

@epszaw epszaw added type:bug Something isn't working theme:hermione labels Aug 22, 2023
@epszaw epszaw changed the title change skipped tests handling logic Change skipped tests handling logic Aug 22, 2023
@epszaw epszaw force-pushed the issue-757-fix-hermione-skipped-tests-detection-strategy branch from eb7a4d5 to 6419ab2 Compare August 22, 2023 14:13
@epszaw epszaw requested a review from baev August 22, 2023 14:20
baev
baev requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test

@epszaw epszaw force-pushed the issue-757-fix-hermione-skipped-tests-detection-strategy branch from 6419ab2 to b466e45 Compare September 4, 2023 08:41
@epszaw
Copy link
Member Author

epszaw commented Sep 4, 2023

@baev added the test

@baev baev merged commit cd821cc into master Sep 4, 2023
5 checks passed
@baev baev deleted the issue-757-fix-hermione-skipped-tests-detection-strategy branch September 4, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:hermione type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When only one test is running allure report for allure-hermione generates result with all tests in the project
2 participants
@epszaw @baev