Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hpos compatibility #219

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

ClaireAlma
Copy link
Contributor

@ClaireAlma ClaireAlma commented Feb 20, 2024

Reason for change

HPOS compatibility

Task

How to test

  • uninstall wmpl

  • In the admin go to Pages -> checkout -> edit

  • select the block
    image

  • click on switch to classic checkout
    image

  • click on update in top of the page

  • In Woocommerce admin : go to woocommerce -> settings -> advanced -> features

  • We can now enabled High Performance order storage and compatibility mode

  • Place alma orders

  • Then do a full refund with alma, partial refund and check if you have the notice on the right and the notice in the page
    image

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it

  • The PR implements the changes asked in the referenced task / issue

  • The automated tests are compliant with the testing strategy

  • The tests are relevant, and cover the corner/error cases, not only the happy path

  • You understand the impact of this PR on existing code/features

  • The changes include adequate logging and Datadog traces

  • Documentation is updated (API, developer documentation, ADR, Notion...)

@ClaireAlma ClaireAlma self-assigned this Feb 20, 2024
@ClaireAlma ClaireAlma marked this pull request as ready for review February 20, 2024 12:41
Copy link
Contributor

@joyet-simon joyet-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests done

@ClaireAlma ClaireAlma merged commit e55ed32 into develop Feb 22, 2024
3 of 4 checks passed
@ClaireAlma ClaireAlma deleted the feature/ECOM-1381/fix-hpos-compatibility branch February 22, 2024 08:46
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClaireAlma ClaireAlma mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants