-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate credit on in page #282
Merged
joyet-simon
merged 2 commits into
develop
from
feature/ecom-2072-wc-integrate-credit-for-in-page
Oct 4, 2024
Merged
Integrate credit on in page #282
joyet-simon
merged 2 commits into
develop
from
feature/ecom-2072-wc-integrate-credit-for-in-page
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
QA test OK |
This comment has been minimized.
This comment has been minimized.
webaaz
reviewed
Oct 4, 2024
webaaz
reviewed
Oct 4, 2024
Benjamin-Freoua-Alma
approved these changes
Oct 4, 2024
⏳E2E tests are currently running. |
|
webaaz
reviewed
Oct 4, 2024
webaaz
approved these changes
Oct 4, 2024
❌ E2E tests have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Code changes
We add a new gataway for inpage on credit.
How to test
As a reviewer, you are encouraged to test the PR locally.
Run unit tests locally.
Connect to the QA env, check if inpage is activated, add a product to the cart, go to the checkout and try to pay with the p10x.
Checklist for authors and reviewers
Non applicable