Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate credit on in page #282

Merged

Conversation

joyet-simon
Copy link
Contributor

@joyet-simon joyet-simon commented Oct 3, 2024

Reason for change

Linear task

Code changes

We add a new gataway for inpage on credit.

How to test

As a reviewer, you are encouraged to test the PR locally.

Run unit tests locally.
Connect to the QA env, check if inpage is activated, add a product to the cart, go to the checkout and try to pay with the p10x.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner October 3, 2024 15:36

This comment has been minimized.

@Benjamin-Freoua-Alma
Copy link
Member

QA test OK

This comment has been minimized.

Copy link

github-actions bot commented Oct 4, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarqubecloud bot commented Oct 4, 2024

Copy link

github-actions bot commented Oct 4, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@joyet-simon joyet-simon merged commit 5bd6f80 into develop Oct 4, 2024
4 of 6 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-2072-wc-integrate-credit-for-in-page branch October 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants