Fix/pre commit

[webaaz]

Reason for change

For now pre-commit hook works locally, and it's a pain to change PHP version each time we need composer or phpcs.

PHPCS should work into a docker container, we don't need PHP locally.

Linear task

Code changes

Dockerfiles

How to test

As a reviewer, you are encouraged to test the PR locally.

You can test pre-commit hook

Checklist for authors and reviewers

• The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
• The PR implements the changes asked in the referenced task / issue
• The automated tests are compliant with the testing strategy
• The tests are relevant, and cover the corner/error cases, not only the happy path
• You understand the impact of this PR on existing code/features
• The changes include adequate logging and Datadog traces
• Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

[carine-bonnafous]

Maybe we could add the build command of phpcs/phpcbf dockers in the bin/coding-standard scripts ? It may not be clear for everyone that it is a prerequisite to have both image built for the pre-commit hook to work.

On my side, I get this error at pre-commit : ERROR: Referenced sniff "WordPress-Extra" does not exist : Do you have an idea about that ?

Also, but it may be a personal preference, I was wondering if we could keep only one dockerfile with PHP5.6, with everything installed, and thus having only one image for all commands requiring PHPH5.6 ?

[github-actions]

⏳E2E tests are currently running.
➡️ You can follow their progression here.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 50%)
3 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[github-actions]

❌ E2E tests have failed.
➡️ You can find the results here.