Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named export toast #92

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

silverwind
Copy link
Contributor

I'm having some issues with the types on the default toast export not working and I think having a named export would resolve it for me, so this adds it.

As for the actual reason why that type is not working, I have no idea, here are my compilerOptions.

@silverwind
Copy link
Contributor Author

Meanwhile I have switched to createToast which does not have these type issues for me, being a named export, so I don't strictly need this anymore.

@almond-bongbong
Copy link
Owner

@silverwind Thank you for adding the named export! This change will greatly help me in resolving the type issues related to the default export. Also, your solution using createToast is very insightful.

I appreciate your valuable contribution and look forward to more in the future!

@silverwind
Copy link
Contributor Author

Yeah, I definitely prefer named exports because they work reliably as opposed to default exports. Could even go further and deprecate/remove the default export in a major version.

@almond-bongbong almond-bongbong merged commit bb59a5e into almond-bongbong:master Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants