-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend Order API with commission_type #462
base: master
Are you sure you want to change the base?
Conversation
185f010
to
b554eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Left small comments.
@@ -0,0 +1,182 @@ | |||
from alpaca.broker.client import BrokerClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
assert reqmock.call_count == 2 | ||
assert isinstance(mo_response, Order) | ||
assert mo_response.status == OrderStatus.ACCEPTED | ||
assert mo_response.commission == 1.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like this?
assert mo_response.commission == 1.25 | |
assert mo_response.commission == 0 | |
assert mo_response.commission_bps == 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
efc9a61
Context
Extend Order API with a new field called
commission_type
.Possible values:
Changes