fixes mypy issues

alpaka-group · Feb 12, 2024 · 708c513 · 708c513
1 parent 6fb8d2e
commit 708c513
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/bashi/generator.py b/bashi/generator.py
@@ -3,7 +3,7 @@
 from typing import Dict, List
 from collections import OrderedDict
 
-from covertable import make
+from covertable import make  # type: ignore
 
 from bashi.types import (
     Parameter,
@@ -43,7 +43,7 @@ def generate_combination_list(
 
     # convert List[Dict[Parameter, ParameterValue]] to CombinationList
     for all_pair in all_pairs:
-        tmp_comb: Combination = OrderedDict()
+        tmp_comb: Combination = OrderedDict({})
         # covertable does not keep the ordering of the parameters
         # therefore we sort it
         for param in parameter_value_matrix.keys():

diff --git a/bashi/utils.py b/bashi/utils.py
@@ -105,14 +105,14 @@ def create_parameter_value_pair(  # pylint: disable=too-many-arguments
     if isinstance(value_version1, packaging.version.Version):
         parsed_value_version1: packaging.version.Version = value_version1
     else:
-        parsed_value_version1: packaging.version.Version = packaging.version.parse(
+        parsed_value_version1: packaging.version.Version = packaging.version.parse(  # type: ignore
             str(value_version1)
         )
 
     if isinstance(value_version2, packaging.version.Version):
         parsed_value_version2: packaging.version.Version = value_version2
     else:
-        parsed_value_version2: packaging.version.Version = packaging.version.parse(
+        parsed_value_version2: packaging.version.Version = packaging.version.parse(  # type: ignore
             str(value_version2)
         )
 

diff --git a/bashi/validate.py b/bashi/validate.py
@@ -276,7 +276,7 @@ def check_filter_chain(row: ParameterValueTuple) -> bool:
     return all_true == 4
 
 
-def main():
+def main() -> None:
     """Entry point for the application."""
     args = get_args()
 

diff --git a/bashi/versions.py b/bashi/versions.py
@@ -119,7 +119,8 @@ def is_supported_version(name: ValueName, version: ValueVersion) -> bool:
     on: str = "1.0.0"
 
     local_versions[CLANG_CUDA] = local_versions[CLANG]
-    local_versions[ALPAKA_ACC_GPU_CUDA_ENABLE] = [off] + VERSIONS[NVCC]
+    local_versions[ALPAKA_ACC_GPU_CUDA_ENABLE] = [off]
+    local_versions[ALPAKA_ACC_GPU_CUDA_ENABLE] += VERSIONS[NVCC]
 
     for backend_name in BACKENDS:
         if backend_name != ALPAKA_ACC_GPU_CUDA_ENABLE: