Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter rule: CMake <=3.18 does not support Clang-CUDA #49

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

YuriiPerets
Copy link
Contributor

@YuriiPerets YuriiPerets commented Sep 5, 2024

fix: #34

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (a92ebbe) to head (6051cd3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   94.80%   94.87%   +0.07%     
==========================================
  Files          10       10              
  Lines         654      663       +9     
  Branches      196      200       +4     
==========================================
+ Hits          620      629       +9     
  Misses         15       15              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_filter_software_dependency.py Outdated Show resolved Hide resolved
tests/test_filter_software_dependency.py Outdated Show resolved Hide resolved
tests/test_filter_software_dependency.py Outdated Show resolved Hide resolved
@SimeonEhrig
Copy link
Member

To find linter errors with pylint and mypy, you should install the tools locally:

pip3 install pylint mypy

Afterwards you can lint your code locally with:

mypy src/bashi
mypy src/bashiValidate/validate.py
mypy example
pylint src/bashi
pylint src/bashiValidate/validate.py
pylint example

tests/test_results.py Outdated Show resolved Hide resolved
src/bashi/results.py Outdated Show resolved Hide resolved
@YuriiPerets YuriiPerets marked this pull request as ready for review September 6, 2024 12:52
@SimeonEhrig SimeonEhrig changed the title Draft: Added new filter rule filter rule: CMake <=3.18 does not support Clang-CUDA Sep 9, 2024
@SimeonEhrig SimeonEhrig merged commit cc789bd into alpaka-group:main Sep 9, 2024
8 checks passed
@YuriiPerets YuriiPerets deleted the filterClangCudaCmake branch September 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add filter rule: cmake older than 3.19 does not work togehter with clang as CUDA compiler
3 participants