implement the FilterAdapter #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FilterAdapter provides a nice interface of allpairspy filter rules.
SimeonEhrig
force-pushed
the
FilterAdapter
branch
from
abbf873
to
8517e25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
+ Coverage 33.33% 73.91% +40.57%
===========================================
Files 2 3 +1
Lines 9 23 +14
Branches 1 3 +2
===========================================
+ Hits 3 17 +14
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Python 3.8 produces a type error if we use OrderedDict with types for key and value. There is no easy solution for the problem except do not use type hints but the hints brings some benefits. Therefor and because the project is quiet new and do not ues Python 3.8 in our CI, I drop the support for Python 3.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FilterAdapter provides a nice interface of allpairspy filter rules.