Add filters and setup pairwise generator #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add empty filters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 92.30% 95.00% +2.69%
==========================================
Files 5 10 +5
Lines 91 200 +109
Branches 14 42 +28
==========================================
+ Hits 84 190 +106
Misses 6 6
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. |
- introduce new type ParameterValueSingle - add option to remove_parameter_value_pair() remove all pairs only by given name independent of the version number
- Both library provides an pair-wise generator algorithm. - There is a know bug in the allpairspy library, which causes that not all valid parameter-value-pairs are generated, if filter rules are used. The bug exists since two years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is complex, because it integrates the key component of the library, the pair-wise generator. During the work in the PR, I found a bug in the allpairspy library, which causes that not all valid pairs are generated, if filter functions are used.
Therefore I switched to the covertable library.
The PR contains following changes:
ParamterValueTupleto a named tupleParamterValueSingleParamterValueTuplefrom a list of expected parameter value pairs