Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover Client Checkpoint Runner #565

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Prover Client Checkpoint Runner #565

wants to merge 4 commits into from

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Dec 26, 2024

Description

Enables Prover Client Checkpoint Runner

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-878

@MdTeach MdTeach requested a review from prajwolrg December 26, 2024 19:28
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.

Project coverage is 57.10%. Comparing base (4b4589d) to head (c03188b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/prover-client/src/checkpoint_runner/runner.rs 0.00% 36 Missing ⚠️
bin/prover-client/src/checkpoint_runner/submit.rs 0.00% 19 Missing ⚠️
bin/prover-client/src/main.rs 0.00% 14 Missing ⚠️
bin/prover-client/src/checkpoint_runner/fetch.rs 0.00% 13 Missing ⚠️
bin/prover-client/src/prover_manager.rs 0.00% 9 Missing ⚠️
bin/prover-client/src/operators/checkpoint.rs 0.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   57.36%   57.10%   -0.27%     
==========================================
  Files         308      311       +3     
  Lines       31493    31584      +91     
==========================================
- Hits        18067    18035      -32     
- Misses      13426    13549     +123     
Files with missing lines Coverage Δ
bin/prover-client/src/args.rs 0.00% <ø> (ø)
bin/prover-client/src/operators/checkpoint.rs 0.00% <0.00%> (ø)
bin/prover-client/src/prover_manager.rs 0.00% <0.00%> (ø)
bin/prover-client/src/checkpoint_runner/fetch.rs 0.00% <0.00%> (ø)
bin/prover-client/src/main.rs 0.00% <0.00%> (ø)
bin/prover-client/src/checkpoint_runner/submit.rs 0.00% <0.00%> (ø)
bin/prover-client/src/checkpoint_runner/runner.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants