Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some constants to config #625

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Move some constants to config #625

merged 4 commits into from
Feb 3, 2025

Conversation

sapinb
Copy link
Contributor

@sapinb sapinb commented Jan 21, 2025

Description

Moving some hardcoded constants to be configurable.
Block assembly related code has not been touched currently to avoid conflicting with existing PRs.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-937

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 37.64706% with 53 lines in your changes missing coverage. Please review.

Project coverage is 54.74%. Comparing base (cd459b3) to head (938c7c4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
bin/bridge-client/src/modes/operator/bootstrap.rs 0.00% 12 Missing ⚠️
crates/btcio/src/broadcaster/handle.rs 0.00% 10 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 9 Missing ⚠️
bin/strata-client/src/args.rs 0.00% 8 Missing ⚠️
crates/config/src/btcio.rs 0.00% 5 Missing ⚠️
crates/btcio/src/rpc/client.rs 85.00% 3 Missing ⚠️
bin/prover-client/src/main.rs 0.00% 2 Missing ⚠️
bin/strata-client/src/helpers.rs 0.00% 2 Missing ⚠️
crates/btcio/src/broadcaster/task.rs 0.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   54.79%   54.74%   -0.05%     
==========================================
  Files         313      313              
  Lines       33460    33527      +67     
==========================================
+ Hits        18333    18356      +23     
- Misses      15127    15171      +44     
Files with missing lines Coverage Δ
bin/bridge-client/src/args.rs 0.00% <ø> (ø)
bin/prover-client/src/args.rs 0.00% <ø> (ø)
crates/btcio/src/test_utils.rs 56.09% <100.00%> (ø)
crates/config/src/config.rs 96.07% <100.00%> (+0.24%) ⬆️
crates/util/python-utils/src/drt.rs 87.26% <100.00%> (+0.08%) ⬆️
bin/prover-client/src/main.rs 0.00% <0.00%> (ø)
bin/strata-client/src/helpers.rs 0.00% <0.00%> (ø)
crates/btcio/src/broadcaster/task.rs 87.46% <0.00%> (-0.23%) ⬇️
crates/btcio/src/rpc/client.rs 85.86% <85.00%> (+0.33%) ⬆️
crates/config/src/btcio.rs 72.22% <0.00%> (-27.78%) ⬇️
... and 4 more

... and 7 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Commit: 9cc0522

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 98,041
CL_BLOCK 58,268
L1_BATCH 30,387,702
L2_BATCH 5,473
CHECKPOINT 15,255

delbonis
delbonis previously approved these changes Jan 28, 2025
@sapinb sapinb force-pushed the STR-559-move-constants branch from 2a8cb6d to b0f834d Compare February 3, 2025 06:19
@sapinb sapinb marked this pull request as ready for review February 3, 2025 06:20
@sapinb sapinb requested review from a team as code owners February 3, 2025 06:20
prajwolrg
prajwolrg previously approved these changes Feb 3, 2025
Rajil1213
Rajil1213 previously approved these changes Feb 3, 2025
@sapinb sapinb dismissed stale reviews from Rajil1213, prajwolrg, and delbonis via 938c7c4 February 3, 2025 08:48
@sapinb sapinb requested a review from a team as a code owner February 3, 2025 08:48
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 938c7c4

@storopoli storopoli added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit a1a2e46 Feb 3, 2025
18 of 19 checks passed
@storopoli storopoli deleted the STR-559-move-constants branch February 3, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants