Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str 867 update l1 reader worker #627

Open
wants to merge 22 commits into
base: STR-402-rework-protocol-op-types
Choose a base branch
from

Conversation

bewakes
Copy link
Contributor

@bewakes bewakes commented Jan 22, 2025

Description

This PR does the following:

  1. Use L1BlockManager instead of Database in reader task.
  2. Remove consensus-logic dependency in btcio(thereby avoiding a possible cyclic dependency) by introducing a trait EventSubmitter which provides interface to submit events to csm.
  3. Remove l1_reader mod from strata-client bin and move the init logic to btcio/reader.
  4. Remove l1_handler from consensus-logic and rename it to utils which now contains only verify_proof function. The rest of the l1 persistent logic that was present there has been moved to btcio/reader.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Commit: 3c22d4a

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,499
EL_BLOCK 101,656
CL_BLOCK 57,372
L1_BATCH 30,386,860
L2_BATCH 5,473
CHECKPOINT 15,895

@bewakes bewakes force-pushed the STR-402-rework-protocol-op-types branch 2 times, most recently from fcf9d7c to 5365d49 Compare January 27, 2025 06:43
@bewakes bewakes force-pushed the STR-402-rework-protocol-op-types branch from 88242dd to 92935f4 Compare January 29, 2025 06:36
@bewakes bewakes force-pushed the STR-867-update-l1-reader-worker branch from 89fc287 to fb7bfef Compare January 29, 2025 06:43
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 41.81034% with 135 lines in your changes missing coverage. Please review.

Please upload report for BASE (STR-402-rework-protocol-op-types@92935f4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/btcio/src/reader/query.rs 59.00% 66 Missing ⚠️
crates/consensus-logic/src/util.rs 0.00% 35 Missing ⚠️
crates/btcio/src/reader/handler.rs 0.00% 19 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 13 Missing ⚠️
crates/consensus-logic/src/csm/ctl.rs 0.00% 2 Missing ⚠️
@@                         Coverage Diff                         @@
##             STR-402-rework-protocol-op-types     #627   +/-   ##
===================================================================
  Coverage                                    ?   56.18%           
===================================================================
  Files                                       ?      319           
  Lines                                       ?    33900           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    19046           
  Misses                                      ?    14854           
  Partials                                    ?        0           
Files with missing lines Coverage Δ
bin/strata-client/src/rpc_server.rs 0.00% <ø> (ø)
...rates/consensus-logic/src/csm/client_transition.rs 56.56% <ø> (ø)
crates/consensus-logic/src/fork_choice_manager.rs 0.00% <ø> (ø)
crates/state/src/sync_event.rs 0.00% <ø> (ø)
crates/storage/src/managers/l1.rs 10.75% <100.00%> (ø)
crates/consensus-logic/src/csm/ctl.rs 0.00% <0.00%> (ø)
bin/strata-client/src/main.rs 0.00% <0.00%> (ø)
crates/btcio/src/reader/handler.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/util.rs 0.00% <0.00%> (ø)
crates/btcio/src/reader/query.rs 46.27% <59.00%> (ø)

@bewakes bewakes force-pushed the STR-867-update-l1-reader-worker branch from 2795019 to a9bba27 Compare January 30, 2025 06:33
@bewakes bewakes marked this pull request as ready for review January 30, 2025 06:38
@bewakes bewakes requested review from a team as code owners January 30, 2025 06:38
@bewakes bewakes force-pushed the STR-402-rework-protocol-op-types branch from de14ade to 8938977 Compare January 30, 2025 12:27
@bewakes bewakes requested review from a team as code owners January 30, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant