-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str 867 update l1 reader worker #627
Open
bewakes
wants to merge
22
commits into
STR-402-rework-protocol-op-types
Choose a base branch
from
STR-867-update-l1-reader-worker
base: STR-402-rework-protocol-op-types
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Str 867 update l1 reader worker #627
bewakes
wants to merge
22
commits into
STR-402-rework-protocol-op-types
from
STR-867-update-l1-reader-worker
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit: 3c22d4a SP1 Performance Test Results
|
bewakes
force-pushed
the
STR-402-rework-protocol-op-types
branch
2 times, most recently
from
January 27, 2025 06:43
fcf9d7c
to
5365d49
Compare
bewakes
force-pushed
the
STR-402-rework-protocol-op-types
branch
from
January 29, 2025 06:36
88242dd
to
92935f4
Compare
bewakes
force-pushed
the
STR-867-update-l1-reader-worker
branch
from
January 29, 2025 06:43
89fc287
to
fb7bfef
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## STR-402-rework-protocol-op-types #627 +/- ##
===================================================================
Coverage ? 56.18%
===================================================================
Files ? 319
Lines ? 33900
Branches ? 0
===================================================================
Hits ? 19046
Misses ? 14854
Partials ? 0
|
bewakes
force-pushed
the
STR-867-update-l1-reader-worker
branch
from
January 30, 2025 06:33
2795019
to
a9bba27
Compare
bewakes
force-pushed
the
STR-402-rework-protocol-op-types
branch
from
January 30, 2025 12:27
de14ade
to
8938977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
L1BlockManager
instead ofDatabase
in reader task.consensus-logic
dependency inbtcio
(thereby avoiding a possible cyclic dependency) by introducing a traitEventSubmitter
which provides interface to submit events to csm.l1_reader
mod fromstrata-client
bin and move the init logic tobtcio/reader
.l1_handler
fromconsensus-logic
and rename it toutils
which now contains onlyverify_proof
function. The rest of the l1 persistent logic that was present there has been moved tobtcio/reader
.Type of Change
Notes to Reviewers
Checklist
Related Issues