Skip to content

Commit

Permalink
core, commons: Remove dead code and TODOs
Browse files Browse the repository at this point in the history
See #300 and #274
  • Loading branch information
lorenzleutgeb committed Dec 1, 2021
1 parent c65b8ea commit d7f7189
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@ class PredicateImpl implements Predicate {
this.solverInternal = solverInternal;
}

static PredicateImpl getInstance(String symbol, int arity) {
return getInstance(symbol, arity, false, false);
}

static PredicateImpl getInstance(String symbol, int arity, boolean internal) {
return getInstance(symbol, arity, internal, false);
}

static PredicateImpl getInstance(String symbol, int arity, boolean internal, boolean solverInternal) {
return INTERNER.intern(new PredicateImpl(symbol, arity, internal, solverInternal));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
*
* Copyright (c) 2017-2018, the Alpha Team.
*/
class BasicLiteralImpl extends AbstractLiteral implements BasicLiteral { // TODO could we parameterize Literal with Atom type?
class BasicLiteralImpl extends AbstractLiteral implements BasicLiteral {

BasicLiteralImpl(BasicAtom atom, boolean positive) {
super(atom, positive);
Expand Down
4 changes: 2 additions & 2 deletions alpha-core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ val antlrVersion = "4.7"
val stringtemplateVersion = "4.0.8"

dependencies {
api(project(":alpha-api")) // TODO does it make more sense to use implementation scope?
api(project(":alpha-commons")) // TODO does it make more sense to use implementation scope?
api(project(":alpha-api"))
api(project(":alpha-commons"))

// We need to give the ANTLR Plugin a hint.
antlr("org.antlr:antlr4:${antlrVersion}")
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit d7f7189

Please sign in to comment.