Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality of DefaultSolver a bit. #254

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

AntoniusW
Copy link
Collaborator

Addresses issue #251.

@AntoniusW AntoniusW requested a review from rtaupe May 7, 2020 13:42
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #254 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
+ Coverage     77.00%   77.02%   +0.01%     
  Complexity     2068     2068              
============================================
  Files           150      150              
  Lines          6784     6781       -3     
  Branches       1187     1186       -1     
============================================
- Hits           5224     5223       -1     
+ Misses         1165     1164       -1     
+ Partials        395      394       -1     
Impacted Files Coverage Δ Complexity Δ
...va/at/ac/tuwien/kr/alpha/solver/DefaultSolver.java 62.50% <83.33%> (+0.30%) 59.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fbdf4...582bbeb. Read the comment docs.

Copy link
Collaborator

@madmike200590 madmike200590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@madmike200590 madmike200590 merged commit 565423f into master Jul 9, 2020
@madmike200590 madmike200590 deleted the issue251 branch July 9, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants