Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused configuration and code #1430

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Remove unused configuration and code #1430

merged 8 commits into from
Feb 3, 2025

Conversation

AgaDufrat
Copy link
Contributor

@AgaDufrat AgaDufrat commented Jan 30, 2025 •
edited
Loading

Removes unused code and configuration to reduce complexity of the codebase.
See commits for details.

@AgaDufrat AgaDufrat self-assigned this Jan 30, 2025
@AgaDufrat
Don’t turn off debug mode in test
4974bc1 
This is helpful during development.
The tests have been made fasters now.
@AgaDufrat
Remove config.action_dispatch.rescue_responses
bdde263 
We are no longer raising those errors.
Equivalent ones are handled in the ApplicationController.
@AgaDufrat
Remove config.filter_parameters from config/application.rb
8f2284e 
Those params were added to configure Raven (Sentry SDK)
929fda7

We migrated over to Sentry Ruby SDK, which protects sensitive data by default
so we no longer need to configure those.
2dd560e

The default configuration is now in config/initializers/filter_parameter_logging.rb
@AgaDufrat
Remove unused GA tracking code
f78404d 
No longer used. Google Tag Manager is used instead.
@AgaDufrat
Remove secrets handling related to GOV.UK PaaS
698226c 
This app is no longer hosted on GOV.UK PaaS and VCAP_SERVICES is not defined
anywhere
@AgaDufrat
Remove references to ElasticSearch
a1c4612 
We migrated to use Solr.
@AgaDufrat
Remove outdated Kaminari patch
3ac9195 
This is no longer relevant because we migrated off ElasticSearch/OpenSearch.
Kaminari is now upgraded to the patched version 1.2.1
GHSA-r5jw-62xg-j433
@AgaDufrat
Remove printing license constrains
3be653b 
This was added in accidentally - it was only used in development.
We don't want to print those.
@AgaDufrat AgaDufrat force-pushed the remove-unused-config branch from 4e6b6d2 to 3be653b Compare February 3, 2025 10:01
@AgaDufrat AgaDufrat marked this pull request as ready for review February 3, 2025 10:03
@AgaDufrat AgaDufrat requested a review from a team February 3, 2025 10:04
@AgaDufrat AgaDufrat merged commit cd5dfa0 into main Feb 3, 2025
7 checks passed
@AgaDufrat AgaDufrat deleted the remove-unused-config branch February 3, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuriloDalRi MuriloDalRi MuriloDalRi approved these changes

Assignees

@AgaDufrat AgaDufrat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgaDufrat @MuriloDalRi