Match pyup config to admin and API #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most of our apps (for example admin and api) we have PyUp configured to look at `requirements.in` and `requirements_for_test.txt` This means we’ll only get warnings about direct dependencies (the ones we specify). In document-download-api we specify `requirements.txt` as well, meaning we also get warnings about indirect dependencies. This commit makes document download consistent with the admin and API apps to reduce the amount of noise. Also worth noting that `requirements-dev.txt` and `requirements-app.txt` no longer exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most of our apps (for example admin and api) we have PyUp configured to look at
requirements.inandrequirements_for_test.txtThis means we’ll only get warnings about direct dependencies (the ones we specify).
In document-download-api we specify
requirements.txtas well, meaning we also get warnings about indirect dependencies.This commit makes document download consistent with the admin and API apps to reduce the amount of noise.
Also worth noting that
requirements-dev.txtandrequirements-app.txtno longer exist.🚨⚠️ This will be deployed automatically all the way to production when you click merge ⚠️ 🚨
For more information, including how to check this deployment on preview or staging first before it goes to production, see our team wiki section on deployment