ServiceApiClient: refactor construction, use thread-local instances #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
force-pushed
the
ris-service-api-client-thread-safe
branch
3 times, most recently
from
ae535eb
to
89339c2
Compare
newer versions of the internal api_client are not thread-safe, so we need to keep thread-local copies of this using LazyLocalGetter if we want to use them
can switch to a non-thread-safe version now that we use per-thread copies
risicle
force-pushed
the
ris-service-api-client-thread-safe
branch
from
89339c2
to
e51c1eb
Compare
CrystalPea
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tangential to https://trello.com/c/ORGrd1jn/498-upgrade-docker-images-for-our-ecs-apps-to-debian-bookworm
This app uses eventlet, so
ServiceApiClientuse really needs to be made thread-safe because of its internalrequests.Session.🚨⚠️ This will be deployed automatically all the way to production when you click merge ⚠️ 🚨
For more information, including how to check this deployment on preview or staging first before it goes to production, see our team wiki section on deployment