[DO NOT MERGE] Open filter, on mobile, on licence finder pages #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
changed the title
jon-kirwan
added
the
do-not-merge
jon-kirwan
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
e14999c
to
bae4dc0
Compare
jon-kirwan
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
bae4dc0
to
748784b
Compare
jon-kirwan
changed the title
MartinJJones
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
748784b
to
7c64e53
Compare
MartinJJones
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
7c64e53
to
e8c05c8
Compare
jon-kirwan
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
e8c05c8
to
6faf090
Compare
By using matchedMedia we can be sure we are in a mobile or desktop view, previously we simply checked if the filter view was closed, but the state of this was not dependant on mobile or desktop.
jon-kirwan
force-pushed
the
open-filter-on-licence-finder-pages
branch
from
6faf090
to
ea824b5
Compare
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Open filter, on mobile, on licence finder pages
Why
For licence finder user research testing so filters are more clearly visible for mobile testing
Visual changes
Anything else