Add scroll tracking to finders #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds scroll tracking module to the base template for all finders - uses the default scroll track mode of tracking percentage scrolled, every 20%
andysellick
changed the title
AshGDS
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
@andysellick Looks good, but I've noticed that I can't get the 100% scrolled event to activate - is that expected?
|
@andysellick I think var pageHeight = Math.max(body.scrollHeight, body.offsetHeight, html.clientHeight, html.scrollHeight, html.offsetHeight) - 1 |
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds scroll tracking to finders, e.g.
/search/all. Should work for all finders, check the page at/for a full list to test.NOTE this PR depends upon the scroll tracking code in
static, it's currently only on integration.Why
Part of the GA4 migration
Visual changes
None.
Trello card: https://trello.com/c/r75BqxiW/608-scroll-tracking-percent-type-finders