Implement FiltersPresenter#reset_url
#3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
approved these changes
Oct 10, 2024
This returns the URL used for the "Clear all" link on both the filter summary and filter panel in the new "all content" finder UI. - Add real implementation for `FiltersPresenter#reset_url`, merging the query parameters keys from every applied facet and then removing them from the current URL - Add `UrlBuilder#url_except_keys` to remove all given keys from the current finder URL's query parameters - Refactor duplication into a `#applied_filters` private method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the URL used for the "Clear all" link on both the filter
summary and filter panel in the new "all content" finder UI.
FiltersPresenter#reset_url, merging thequery parameters keys from every applied facet and then removing them
from the current URL
UrlBuilder#url_except_keysto remove all given keys from thecurrent finder URL's query parameters
#applied_filtersprivate methodNote this code could be simpler if we just removed all query params except the keyword, but then we would also lose any other query parameters that are unrelated to the filtering/sorting.
Review app testing