New "all content" finder UI tweaks #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
force-pushed
the
visual-tweaks
branch
from
172849c
to
bbe3ff0
Compare
csutter
force-pushed
the
visual-tweaks
branch
from
461b54b
to
e92e019
Compare
csutter
force-pushed
the
visual-tweaks
branch
from
e92e019
to
461b54b
Compare
kevindew
reviewed
Oct 10, 2024
This causes the button's text to be added to the query parameters, which we don't need and clutters up the analytics.
- Move overall UI (except breadcrumbs) into a `app-all-content-finder` container - Add margin to container on tablet+
This needs to be made more resilient for Safari (and some older browsers) by targeting the marker's (triangle) pseudo-element.
This turned out to be a nasty Webkit bug, which generally seems to be poor at dealing with text-decoration-thickness.
- Inline spelling suggestion code from old UI partial - Add wrapper div with appropriate margins
This removes the separate page heading, and uses the variant of the `search` component that comes with a heading-wrapped label instead to avoid duplication.
- Reduce margin between heading and "pills" - Increase gap between "pills" - Increase bottom padding of component
This still creates a mildly jarring change at 770px but makes things look nicer on _some_ portrait orientation tablets (iPad is still too wide to get tablet breakpoint).
There's a `govuk-width-container` within another one, which is unnecessary and causes display issues at some breakpoints.
Use ERB to generate the form so the source looks more manageable, and actually close the form element.
This uses the new `equal_item_spacing` option on the document list component, and returns to using the standard top border on list elements (and adjusting the filter summary component to remove its bottom border and tighten its bottom spacing).
csutter
force-pushed
the
visual-tweaks
branch
from
461b54b
to
9317af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a number of small UI tweaks following a design review:
nameattr (this causes the button's text to be added to the query parameters, which we don't need and clutters up the analytics)detailselement on Webkit and older Blink browsers (by hiding the::markerpseudo-element)text-decoration-thicknessonbuttonelements, and fixed by applying it to an extra innerspaninstead)equal_item_spacingoption to tighten up display of resultsReview app: https://finder-frontend-pr-3495.herokuapp.com/search/all
Before
After