Skip to content

Commit

Permalink
Fix comment on PR step
Browse files Browse the repository at this point in the history
* Use `html_url` which is the human readable version, `url` points to the GitHub API friendly URL
* Add link to review app URL
  • Loading branch information
sarahseewhy authored and AP-Hunt committed Feb 19, 2025
1 parent 3afc6d0 commit b68bef4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/review_apps_on_pr_change.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,11 @@ jobs:
run: |
cat <<EOF > "${{runner.temp}}/pr-comment.md"
:tada: A review copy of this PR has been deployed! You can reach it at <question whether we want to share the URL>.
:tada: A review copy of this PR has been deployed! You can reach it at ${{steps.deploy.outputs.REVIEW_APP_URL}}.
It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with it. You will need to go to the integration AWS account
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.
EOF
gh pr comment "${{github.event.pull_request.url}}" --body-file "${{runner.temp}}/pr-comment.md"
gh pr comment "${{github.event.pull_request.html_url}}" --body-file "${{runner.temp}}/pr-comment.md"

0 comments on commit b68bef4

Please sign in to comment.