Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor translation keys #1796

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Refactor translation keys #1796

merged 6 commits into from
Feb 26, 2025

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Feb 24, 2025

What problem does this pull request solve?

I have been looking at the translations files and have noticed that we are inconsistent in how we name the variable for the number of a question… this PR makes the keys consistent for question_number, question_text, and route_number.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux marked this pull request as ready for review February 24, 2025 09:45
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from 0596f8b to e6e5eaa Compare February 25, 2025 09:53
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from e6e5eaa to 0a38376 Compare February 25, 2025 11:28
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from 0a38376 to 2b762b1 Compare February 25, 2025 12:05
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from 2b762b1 to 8408a7b Compare February 26, 2025 06:10
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from 8408a7b to acda988 Compare February 26, 2025 09:16
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

Copy link
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, really appreciate the care you've taken over the names 🏅

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch from acda988 to 95c1e9b Compare February 26, 2025 11:06
@lfdebrux lfdebrux enabled auto-merge February 26, 2025 11:07
Copy link

@lfdebrux lfdebrux merged commit 5719a7f into main Feb 26, 2025
4 of 5 checks passed
@lfdebrux lfdebrux deleted the ldeb-refactor-translations branch February 26, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants