-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor translation keys #1796
Conversation
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
0596f8b
to
e6e5eaa
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
e6e5eaa
to
0a38376
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
0a38376
to
2b762b1
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
2b762b1
to
8408a7b
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
8408a7b
to
acda988
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1796.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, really appreciate the care you've taken over the names 🏅
Pass the full objects through rather than unpacking early. This makes it easier to change names of variables later.
Use question instead of page where appropriate
acda988
to
95c1e9b
Compare
|
What problem does this pull request solve?
I have been looking at the translations files and have noticed that we are inconsistent in how we name the variable for the number of a question… this PR makes the keys consistent for
question_number
,question_text
, androute_number
.Things to consider when reviewing