Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PageListComponent #1798

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Feb 24, 2025

What problem does this pull request solve?

Some changes we have made to our designs mean we can remove a bunch of code from the PageListComponent related to numbering routes. This PR also makes some tweaks to the method arguments to be more consistent with other classes in our codebase.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux changed the base branch from main to ldeb-refactor-translations February 24, 2025 11:36
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux force-pushed the ldeb-refactor-translations branch 5 times, most recently from 8408a7b to acda988 Compare February 26, 2025 09:16
@lfdebrux lfdebrux force-pushed the ldeb-refactor-page-list-summary-component branch from ccbf8fc to 1032f17 Compare February 26, 2025 09:19
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux marked this pull request as ready for review February 26, 2025 10:05
thomasiles
thomasiles previously approved these changes Feb 26, 2025
@lfdebrux lfdebrux changed the base branch from ldeb-refactor-translations to main February 26, 2025 11:06
@lfdebrux lfdebrux dismissed thomasiles’s stale review February 26, 2025 11:06

The base branch was changed.

@lfdebrux lfdebrux force-pushed the ldeb-refactor-page-list-summary-component branch from 1032f17 to 0c752b6 Compare February 26, 2025 11:21
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux merged commit 93143dc into main Feb 26, 2025
6 checks passed
@lfdebrux lfdebrux deleted the ldeb-refactor-page-list-summary-component branch February 26, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants