-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PageListComponent #1798
Conversation
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
8408a7b
to
acda988
Compare
ccbf8fc
to
1032f17
Compare
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
1032f17
to
0c752b6
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1798.review.forms.service.gov.uk/. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For more details please see the review app wiki page |
What problem does this pull request solve?
Some changes we have made to our designs mean we can remove a bunch of code from the PageListComponent related to numbering routes. This PR also makes some tweaks to the method arguments to be more consistent with other classes in our codebase.
Things to consider when reviewing