Fix Review app code examples using example.options
#4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
the
🐛 bug
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4202
|
@romaricpascal This change was missed from 7a2d138 🤦♂️ |
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for e29ffd9 |
There was a problem hiding this comment.
Whoops for missing that at the time, didn't occur to me when reviewing to check for leftover offcurences of example.data or even \.data(?!set) (many .dataset that are not relevant).
Cheers for tidying it up! Don't think there's much risk on moving the code partial inside the macro, unless anyone in @alphagov/design-system-developers was planning to reuse that bit specifically?
| @@ -20,6 +20,7 @@ export function renderer(app) { | |||
| const env = nunjucksEnv( | |||
| [join(paths.app, 'src/views')], | |||
| { | |||
| dev: true, // log stack traces | |||
There was a problem hiding this comment.
Ohhh, that's going to be handy for debugging! 🥳
There was a problem hiding this comment.
I discovered it recently and I'm getting bored of adding it 😆
You get to see Nunjucks stack traces right into global/filter code too
colinrotherham
force-pushed
the
fix-preview-code
branch
from
4dce1f0 to
8fa38f4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4202
We missed a change from `example.data` to `example.options` since the `{% for example in componentFixtures.fixtures %}` loop was in a separate file
The dependency `chokidar` is no longer needed for production
Minor speed up for review app performance
Accidentally missed in 7a2d138
colinrotherham
force-pushed
the
fix-preview-code
branch
from
8fa38f4 to
e29ffd9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4202
romaricpascal
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Markup and Macro code rendering in the review app
Macro options were renamed to
example.dataexample.optionsin 7a2d138 via #4042We missed this because the
{% for example in componentFixtures.fixtures %}loop was in a separate fileTo help avoid Nunjucks issues like this in future I've included a few changes such as:
showExamples.njkfor easier debuggingdev: trueto log stack traces etc