Fix specifying multiple domains

This allows multiple allowed domains to be specified
alphagov · Oct 17, 2023 · efc5d59 · efc5d59
1 parent 15acc5e
commit efc5d59
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -9,7 +9,7 @@ import (
 
 type Config struct {
 	Site                 string            `env:"SITE"`
-	AllowedDomains       string            `env:"ALLOWED_DOMAINS"`
+	AllowedDomains       []string          `env:"ALLOWED_DOMAINS" envSeparator:","`
 	UserAgent            string            `env:"USER_AGENT" envDefault:"govukbot"`
 	Headers              map[string]string `env:"HEADERS"`
 	Concurrency          int               `env:"CONCURRENCY" envDefault:"10"`

diff --git a/internal/config/config_test.go b/internal/config/config_test.go
@@ -25,15 +25,15 @@ func TestNewConfig(t *testing.T) {
 			name: "env vars",
 			envVars: map[string]string{
 				"SITE":                 "example.com",
-				"ALLOWED_DOMAINS":      "example.com",
+				"ALLOWED_DOMAINS":      "example.com,foo.bar",
 				"USER_AGENT":           "custom-agent",
 				"HEADERS":              "Test-Header:Test-Value",
 				"CONCURRENCY":          "20",
 				"DISALLOWED_URL_RULES": "rule1,rule2",
 			},
 			expected: &Config{
 				Site:           "example.com",
-				AllowedDomains: "example.com",
+				AllowedDomains: []string{"example.com", "foo.bar"},
 				UserAgent:      "custom-agent",
 				Headers: map[string]string{
 					"Test-Header": "Test-Value",

diff --git a/internal/crawler/crawler.go b/internal/crawler/crawler.go
@@ -29,7 +29,7 @@ func NewCrawler(cfg *config.Config) (*Crawler, error) {
 func newCollector(cfg *config.Config) (*colly.Collector, error) {
 	c := colly.NewCollector(
 		colly.UserAgent(cfg.UserAgent),
-		colly.AllowedDomains(cfg.AllowedDomains),
+		colly.AllowedDomains(cfg.AllowedDomains...),
 		colly.DisallowedURLFilters(cfg.DisallowedURLFilters...),
 		colly.Async(true),
 	)