Fix wrong types in tests. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config.AllowedDomains is a vector of string, not a string. These tests couldn't have ever passed 🙃 Fixing now cos it's blocking updates for critical fixes to the net library such as #4.
sengi
force-pushed
the
sengi/fix-tests
branch
from
01252cf
to
9a39d7b
Compare
|
Oh, of course that wasn't the only thing that was broken in those tests. Sorry, was over-optimistic with the review request there, d'oh. |
|
D'oh I just realised this is the new thing not the old/current one 🙈 I'll leave you in peace! Feel free to close/delete/use this as you like. |
|
Fix in #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config.AllowedDomainsis a slice of strings, not a string. These tests couldn't have ever passed 🙃Fixing now cos it's blocking updates for critical fixes to the net library such as #4.