Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Commit

Permalink
Remove jasmine from test suite
Browse files Browse the repository at this point in the history
As this is now using the gem accordion where there are already jasmine tests, any tests here would just be replicating effort. There's now no point in jasmine being part of this repo as there aren't any js modules to test.
  • Loading branch information
owenatgov committed Feb 12, 2021
1 parent 201e492 commit 2b9062e
Show file tree
Hide file tree
Showing 13 changed files with 3 additions and 11,195 deletions.
2 changes: 0 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ updates:
- dependency-name: slimmer
dependency-type: direct
# Framework gems
- dependency-name: jasmine
dependency-type: direct
- dependency-name: rails
dependency-type: direct
- dependency-name: rspec-rails
Expand Down
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ end

group :development, :test do
gem "govuk_test"
gem "jasmine"
gem "jasmine_selenium_runner"
gem "pry-byebug"
gem "rspec-rails"
gem "rubocop-govuk"
Expand Down
12 changes: 0 additions & 12 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,6 @@ GEM
domain_name (~> 0.5)
i18n (1.8.8)
concurrent-ruby (~> 1.0)
jasmine (3.6.0)
jasmine-core (~> 3.6.0)
phantomjs
rack (>= 1.2.1)
rake
jasmine-core (3.6.0)
jasmine_selenium_runner (3.0.0)
jasmine (~> 3.0)
selenium-webdriver (~> 3.8)
json (2.5.1)
json-schema (2.8.1)
addressable (>= 2.4)
Expand Down Expand Up @@ -180,7 +171,6 @@ GEM
parallel (1.19.2)
parser (2.7.2.0)
ast (~> 2.4.1)
phantomjs (2.1.1.0)
plek (4.0.0)
pry (0.13.1)
coderay (~> 1.1)
Expand Down Expand Up @@ -353,8 +343,6 @@ DEPENDENCIES
govuk_app_config
govuk_publishing_components
govuk_test
jasmine
jasmine_selenium_runner
launchy
plek
pry-byebug
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ If you are using the GDS development virtual machine then the application will b

The test suite includes testing against govuk-content-schemas, so you will need a copy of this repo on your file system. By default this should be in a sibling directory to your project. Alternatively, you can specify their location with the GOVUK_CONTENT_SCHEMAS_PATH environment variable.

jasmine tests are mounted at http://manuals-frontend.dev.gov.uk/specs

All tests can be run using `bundle exec rake` as well.

## Viewing a manual
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ require File.expand_path("config/application", __dir__)
Rails.application.load_tasks

Rake::Task[:default].clear if Rake::Task.task_defined?(:default)
task default: %i[lint spec jasmine:ci]
task default: %i[lint spec]
9 changes: 0 additions & 9 deletions config/initializers/jasmine_rails.rb

This file was deleted.

1 change: 0 additions & 1 deletion config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
end

root to: proc { [404, {}, ["Not found"]] }
mount JasmineRails::Engine => "/specs" if defined?(JasmineRails::Engine)

get "/healthcheck", to: GovukHealthcheck.rack_response
end
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@
"license": "MIT",
"scripts": {
"lint": "yarn run lint:js && yarn run lint:scss",
"lint:js": "standardx 'app/assets/javascripts/**/*.js' 'spec/javascripts/**/*.js'",
"lint:js": "standardx 'app/assets/javascripts/**/*.js'",
"lint:scss": "stylelint app/assets/stylesheets/"
},
"standardx": {
"env": {
"browser": true,
"jquery": true,
"jasmine": true
"jquery": true
},
"globals": [
"GOVUK"
Expand Down
Empty file removed spec/javascripts/helpers/.gitkeep
Empty file.
146 changes: 0 additions & 146 deletions spec/javascripts/support/jasmine.yml

This file was deleted.

7 changes: 0 additions & 7 deletions spec/javascripts/support/jasmine_helper.rb

This file was deleted.

2 changes: 0 additions & 2 deletions spec/javascripts/support/jasmine_selenium_runner.yml

This file was deleted.

Loading

0 comments on commit 2b9062e

Please sign in to comment.