[FOR TESTING WITH LIVEMAIL ENV] Give banner role=status if just an update #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombye
force-pushed
the
change-default-role-for-banner
branch
3 times, most recently
from
306c55e to
25ce419
Compare
We currently use the role of 'alert' for all banners. In recent accessibility testing, the Digital Accessibility Centre (DAC) suggested we should only be using that role for important or time-sensitive updates. This changes the banner component so the default role is 'status' to reflect that. In practice, this will change how the green banners are announced by screen readers.
tombye
force-pushed
the
change-default-role-for-banner
branch
from
25ce419 to
ee276b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the role of 'alert' for all
banners. In recent accessibility testing, the
Digital Accessibility Centre (DAC) suggested we
should only be using that role for important or
time-sensitive updates. This changes the banner
component so the default role is 'status' to
reflect that.
In practice, this will change how the green
banners are announced by screen readers.