[FOR TESTING WITH LIVEMAIL ENV] Announce notification status changes #5390
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombye
force-pushed
the
announce-notification-status
branch
3 times, most recently
from
a20b114 to
ebf0244
Compare
Wrapping a notification's status in a div with role=status ensures it will get announced to screen readers. I've added a prefix to give it the context users of the visual interface get.
tombye
force-pushed
the
announce-notification-status
branch
from
ebf0244 to
802bf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue described in this card:
https://trello.com/c/W61SzMoA/1181-changes-to-status-of-notification-arent-announced-to-screen-readers
Wrapping a notification's status in a div with role=status ensures it will get announced to screen readers. I've added a prefix to give it the context users of the visual interface get.