-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump utils to 82.1.1 #169
Open
quis
wants to merge
5
commits into
main
Choose a base branch
from
bump-utils-82.1.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump utils to 82.1.1 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 82.1.1 * Fix the way we log the request_size. Accessing the data at this point can trigger a validation error early and cause a 500 error ## 82.1.0 * Adds new logging fields to request logging. Namely environment_name, request_size and response_size ## 82.0.0 * Change `PostalAddress` to add `has_no_fixed_abode_address` method. No fixed abode addresses are now considered invalid. ## 81.1.1 * Adds condition to validation to allow TV Numbers (https://www.ofcom.org.uk/phones-and-broadband/phone-numbers/numbers-for-drama/) for UK mobiles ## 81.1.0 * introduce new validation class - `PhoneNumber`, that we will use for services that want to send sms to landline (and in the future this new code can be extended for all phone number validation) * in this new class, we use `phonenumbers` library for validating phone numbers, instead of our custom valdiation code ## 81.0.0 * BREAKING CHANGE: The constructor for `notification_utils.recipient_validation.errors.InvalidPhoneError` - When raising InvalidPhoneError, instead of supplying a custom message, you must create an error by supplying a code from the `InvalidPhoneError.Codes` enum * `InvalidPhoneError.code` will contain this machine-readable code for an exception if you need to examine it later * `InvalidPhoneError.get_legacy_v2_api_error_message` returns a historical error message for use on the public v2 api ## 80.0.1 * Reduces minimum required Gunicorn version for compatibility ## 80.0.0 * Copies additional config files from utils into repos * Renames `version_tools.copy_pyproject_yaml` to `version_tools.copy_config` ## 79.0.1 * Update the `send_ticket_to_zendesk` method of the ZendeskClient to return the ID of the ticket that was created. ## 79.0.0 * Switches on Pyupgrade and a bunch of other more opinionated linting rules ## 78.2.0 * Bumped minimum versions of select subdependencies ## 78.1.0 * Restrict postcodes to valid UK postcode zones ## 78.0.0 * BREAKING CHANGE: recipient validation code has all been moved into separate files in a shared folder. Functionality is unchanged. - Email address validation can be found in `notifications_utils.recipient_validation.email_address` - Phone number validation can be found in `notifications_utils.recipient_validation.phone_number` - Postal address validation can be found in `notifications_utils.recipient_validation.postal_address` * BREAKING CHANGE: InvalidPhoneError and InvalidAddressError no longer extend InvalidEmailError. - if you wish to handle all recipient validation errors, please use `notifications_utils.recipient_validation.errors.InvalidRecipientError` ## 77.2.1 * Change redis delete behaviour to error, rather than end up with stale data, if Redis is unavailable. ## 77.2.0 * `NotifyTask`: include pid and other structured fields in completion log messages *** Complete changes: alphagov/notifications-utils@77.1.1...82.1.1
We excluded this file from version control because it’s copied automatically from utils, so we only need to modify it and track changes there. In theory at least. In practice Dependabot cannot: - cope with having a requirements file which isn’t in the repo - be configured to only look at certain requirements files So I think the best thing to do is keep this file in version control. It already has an automatically generated comment to suggest it shouldn’t be edited manually. Dependabot may try to raise PRs against it, but we can resolve these by updating the upstream version in utils. We can then roll out several version bumps in a single PR per app, rather than several.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some problems last time we tried, but putting it up here so we can try again some time.
82.1.1
82.1.0
82.0.0
PostalAddress
to addhas_no_fixed_abode_address
method. No fixed abode addresses are now considered invalid.81.1.1
81.1.0
PhoneNumber
, that we will use for services that want to send sms to landline (and in the future this new code can be extended for all phone number validation)phonenumbers
library for validating phone numbers, instead of our custom valdiation code81.0.0
notification_utils.recipient_validation.errors.InvalidPhoneError
InvalidPhoneError.Codes
enumInvalidPhoneError.code
will contain this machine-readable code for an exception if you need to examine it laterInvalidPhoneError.get_legacy_v2_api_error_message
returns a historical error message for use on the public v2 api80.0.1
80.0.0
version_tools.copy_pyproject_yaml
toversion_tools.copy_config
79.0.1
send_ticket_to_zendesk
method of the ZendeskClient to return the ID of the ticket that was created.79.0.0
78.2.0
78.1.0
78.0.0
notifications_utils.recipient_validation.email_address
notifications_utils.recipient_validation.phone_number
notifications_utils.recipient_validation.postal_address
notifications_utils.recipient_validation.errors.InvalidRecipientError
77.2.1
77.2.0
NotifyTask
: include pid and other structured fields in completion log messagesComplete changes: alphagov/notifications-utils@77.1.1...82.1.1
Fixes #154
Fixes #153
🚨⚠️ This will be deployed automatically all the way to production when you click merge ⚠️ 🚨
For more information, including how to check this deployment on preview or staging first before it goes to production, see our team wiki section on deployment