[#184549339] App autoscaler upgrade #3529
Merged
+521
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this involves moving almost all jobs out into their own instance groups and changing a lot of naming to be based on ((deployment_name)), meaning quite a bit of hostname adaptation etc
corlettb
force-pushed
the
BC-app-autoscaler-base-manifest-switch
branch
from
0e29cca to
b2d0c79
Compare
corlettb
force-pushed
the
BC-app-autoscaler-base-manifest-switch
branch
from
b2d0c79 to
40b7330
Compare
corlettb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://www.pivotaltracker.com/story/show/184549339
Here be Dragons
This update will change all the bosh job names for the deployment. As such when this gets deployed it will delete all the autoscaler ec2 instances before deploying the new ones.
This will essentially leave us with app-autoscaler downtime. At a guess 10-20 minutes in staging/production. Here is an example deployment in dev.
We should time when we allow this to be rolled out in production so it is done during a quiet period.
How to review
Deploy to a dev env, see the autoscaler acceptance tests passing. Ensure when deploying you set DISABLE_APP_AUTOSCALER_ACCEPTANCE_TESTS=false as part of your pipeline apply.
Check the dev env's alertmanager (https://alertmanager-1.) to ensure AppAutoscalingIsNotScalingSingleProc and AppAutoscalingIsNotScalingMultiProc alerts aren't going off.
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨