Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11681 Encode URL when making axios call #4197

Merged

Conversation

JFSGDS
Copy link
Contributor

@JFSGDS JFSGDS commented Mar 25, 2024

WHAT

When configuring axios-base-client call, encode the url passed in.

HOW

  • Amend configureClient function to encode url passed in from client code issuing axios call.
  • Amend unit test to cover change.

Copy link
Contributor

@iqbalgds iqbalgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JFSGDS JFSGDS marked this pull request as ready for review March 26, 2024 14:35
@JFSGDS JFSGDS merged commit 60338b5 into master Mar 26, 2024
12 checks passed
@JFSGDS JFSGDS deleted the PP-11681_replace_request_with_axios_adminusers_client_encodeURI branch March 26, 2024 14:37
JFSGDS added a commit that referenced this pull request Mar 27, 2024
* PP-11681 Encode URL when making axios call

* PP-11681 Remove encoded URL pact test. Re-evaluate if needed as unit test covers testing functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants