PP-13133 simplified account settings - edit service name #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
force-pushed
the
pp-13133/simplified_account_settings_service_name
branch
from
ce54ea3
to
a19b5f4
Compare
- added middlewares and router supporting simplified account routes - simplified account opt in: directs the user to an appropriate error message if a simplified account route is accessed without the user being opted in and the feature being enabled for the environment - simplified account strategy: retrieves the correct gateway account for the service and account type and makes this available on the request object - added service settings navigation nunjucks template and supporting sass - added settings controllers - index: redirects the user to the correct default setting based on the account type and go live stage of the service - service name: get and post actions for viewing and updating the current service name in english and welsh - email notifications: bare bones implementation of the view - external dependency: express-validations, creates easy to understand validation chains used for parsing request bodies - added utilities - nunjucks filter for correctly capitalising service settings and categories - generator for simplified account paths - settings builder: determines which settings should be visible based on the service go live stage, account type and permissions of the viewing user
nlsteers
force-pushed
the
pp-13133/simplified_account_settings_service_name
branch
from
a19b5f4
to
db300db
Compare
nlsteers
force-pushed
the
pp-13133/simplified_account_settings_service_name
branch
from
c85e838
to
1d94128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT